Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upEcho driver debug messages #2650
Merged
Conversation
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 12, 2018
Echo driver debug messages My primary motivation for getting this was that Angle can behave completely weird and unexpected if it doesn't like the inputs, and the only trace of that change in behavior would be a debug message left behind. Now we are at least going to see it. The PR also fixes one of the errors we get 100% when pre-loading the shaders, since we issue fake draw calls without a VAO bound. r? @glennw <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2650) <!-- Reviewable:end -->
|
|
|
Ugh, angle compiling issue - doesn't look related.
Let's try again (considering that Taskcluster passed on the pull request). |
bors-servo
added a commit
that referenced
this pull request
Apr 12, 2018
Echo driver debug messages My primary motivation for getting this was that Angle can behave completely weird and unexpected if it doesn't like the inputs, and the only trace of that change in behavior would be a debug message left behind. Now we are at least going to see it. The PR also fixes one of the errors we get 100% when pre-loading the shaders, since we issue fake draw calls without a VAO bound. r? @glennw <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2650) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kvark commentedApr 11, 2018
•
edited by larsbergstrom
My primary motivation for getting this was that Angle can behave completely weird and unexpected if it doesn't like the inputs, and the only trace of that change in behavior would be a debug message left behind. Now we are at least going to see it.
The PR also fixes one of the errors we get 100% when pre-loading the shaders, since we issue fake draw calls without a VAO bound.
r? @glennw
This change is