Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove "Layer" space #2679
Merged
Remove "Layer" space #2679
Conversation
|
Thanks, looks good to me. I built Gecko and it compiles and runs with this PR, so @bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 22, 2018
Remove "Layer" space Fixes #2672 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2679) <!-- Reviewable:end -->
|
|
This was referenced Apr 23, 2018
|
For the record, this did break the Gecko build. (see https://bugzilla.mozilla.org/show_bug.cgi?id=1454623#c9) |
|
(from discussion with kats on IRC) The reason I was able to build locally in this case is that I didn't do a FFI bindings regeneration step, so it just happened to work since the memory layout between the two types is exactly the same. Sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nc4rrillo commentedApr 21, 2018
•
edited by larsbergstrom
Fixes #2672
This change is