Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix From conversion from NativeFontHandleWrapper to PathfinderComPtr #2705
Conversation
|
r? @pcwalton |
|
r=me with that nit addressed |
| let system_fc = ::dwrote::FontCollection::system(); | ||
| let font = match system_fc.get_font_from_descriptor(&font_handle.0) { | ||
| Some(font) => font, | ||
| None => { panic!("missing descriptor {:?}", font_handle.0) } |
This comment has been minimized.
This comment has been minimized.
See https://github.com/pcwalton/pathfinder/pull/81 and #2645 - this fixes 1 compile error, where we can't convert from a NativeFontHandleWrapper to a ComPtr. We need this, so that PathfinderFontContext::add_native_font() works correctly.
|
@pcwalton alright, fixed it |
|
@bors-servo r=pcwalton |
|
|
bors-servo
added a commit
that referenced
this pull request
May 1, 2018
Fix From conversion from NativeFontHandleWrapper to PathfinderComPtr See https://github.com/pcwalton/pathfinder/pull/81 and #2645 - this fixes 1 compile error, where we can't convert from a NativeFontHandleWrapper to a ComPtr. We need this, so that PathfinderFontContext::add_native_font() works correctly. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2705) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
fschutt commentedApr 28, 2018
•
edited by larsbergstrom
See https://github.com/pcwalton/pathfinder/pull/81 and #2645 - this fixes 1 compile error, where we can't convert from a NativeFontHandleWrapper to a ComPtr. We need this, so that PathfinderFontContext::add_native_font() works correctly.
This change is