Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle invalid gradient stops #2719

Merged
merged 1 commit into from May 2, 2018
Merged

Conversation

@kvark
Copy link
Member

kvark commented May 2, 2018

This is not strictly required, just something I found useful when investigating captures on WR versions prior to #2709
I still think that the PR is an improvement, since the errors are recoverable.
r? anyone


This change is Reviewable

@Gankra
Copy link
Contributor

Gankra commented May 2, 2018

@bors-servo
Copy link
Contributor

bors-servo commented May 2, 2018

📌 Commit 61c77b7 has been approved by Gankro

@bors-servo
Copy link
Contributor

bors-servo commented May 2, 2018

Testing commit 61c77b7 with merge 7fd6cf7...

bors-servo added a commit that referenced this pull request May 2, 2018
Gracefully handle invalid gradient stops

This is not strictly required, just something I found useful when investigating captures on WR versions prior to #2709
I still think that the PR is an improvement, since the errors are recoverable.
r? anyone

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2719)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 2, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: Gankro
Pushing 7fd6cf7 to master...

@bors-servo bors-servo merged commit 61c77b7 into servo:master May 2, 2018
3 checks passed
3 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@kvark kvark deleted the kvark:gradient branch May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.