Skip to content

/ webrender

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug tracking of display items #2725

Merged
merged 1 commit into from May 28, 2018
Merged

Debug tracking of display items #2725

merged 1 commit into from May 28, 2018

Conversation

@kvark
Copy link
Member

kvark commented May 3, 2018 •
edited by larsbergstrom

This is a different take on #2710

This change is Reviewable
@kvark kvark requested a review from glennw May 3, 2018
@kvark kvark mentioned this pull request May 3, 2018
Merged
@glennw
glennw approved these changes May 3, 2018
View changes
@glennw
Copy link
Member

glennw commented May 3, 2018

Looks fine to me - will need a rebase though. Do you have a preference for this version or the other?
@gw3583
Copy link
Collaborator

gw3583 commented May 10, 2018

@kvark Did we want to get this one merged?
@kvark
Copy link
Member Author

kvark commented May 10, 2018

@gw3583 yep, after a rebase...
@kvark kvark force-pushed the kvark:chase2 branch from dbdb960 to 1ff61f4 May 10, 2018
@kvark
Copy link
Member Author

kvark commented May 10, 2018

Eh, unfortunately this looks way more verbose than the fresh new ? I put just recently. Leaving the code for a few other picky eyes to glance over.
@bors-servo
Copy link
Contributor

bors-servo commented May 11, 2018

☔ The latest upstream changes (presumably #2752) made this pull request unmergeable. Please resolve the merge conflicts.
@gw3583
Copy link
Collaborator

gw3583 commented May 24, 2018

@kvark What's the status of this and #2710 ? Should we close one of them?
@kvark
Debug tracking of display items
Loading status checks…
501c026
@kvark kvark force-pushed the kvark:chase2 branch from 1ff61f4 to 501c026 May 28, 2018
@kvark
Copy link
Member Author

kvark commented May 28, 2018

I'm not super happy about the code structure here, but keeping it rebased isn't optimal either.
@bors-servo r=gw3583
@bors-servo
Copy link
Contributor

bors-servo commented May 28, 2018

📌 Commit 501c026 has been approved by gw3583
@bors-servo
Copy link
Contributor

bors-servo commented May 28, 2018

⌛ Testing commit 501c026 with merge 67f8715...
bors-servo added a commit that referenced this pull request May 28, 2018
@bors-servo
Auto merge of #2725 - kvark:chase2, r=gw3583
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
67f8715 
Debug tracking of display items

This is a different take on #2710

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2725)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 28, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: gw3583
Pushing 67f8715 to master...
@bors-servo bors-servo merged commit 501c026 into servo:master May 28, 2018
3 checks passed
3 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@kvark kvark deleted the kvark:chase2 branch May 28, 2018
@kvark kvark mentioned this pull request May 28, 2018
Merged
bors-servo added a commit that referenced this pull request May 28, 2018
@bors-servo
Auto merge of #2786 - kvark:no-debug, r=staktrace
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
851e745 
Revert "Debug tracking of display items"

This reverts #2725, which causes chaos and destruction in Gecko tests: https://treeherder.mozilla.org/#/jobs?repo=try&revision=12a0fba7254666c7dfba9f4b738093e076de2381&selectedJob=180600645

I'll make sure to test the Gecko binding side before bringing this back.

r? @staktrace

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2786)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request May 28, 2018
@bors-servo
Auto merge of #2786 - kvark:no-debug, r=staktrace
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a28de7f 
Revert "Debug tracking of display items"

This reverts #2725, which causes chaos and destruction in Gecko tests: https://treeherder.mozilla.org/#/jobs?repo=try&revision=12a0fba7254666c7dfba9f4b738093e076de2381&selectedJob=180600645

I'll make sure to test the Gecko binding side before bringing this back.

r? @staktrace

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2786)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request May 28, 2018
@bors-servo
Auto merge of #2786 - kvark:no-debug, r=staktrace
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
41ffac9 
Revert "Debug tracking of display items"

This reverts #2725, which causes chaos and destruction in Gecko tests: https://treeherder.mozilla.org/#/jobs?repo=try&revision=12a0fba7254666c7dfba9f4b738093e076de2381&selectedJob=180600645

I'll make sure to test the Gecko binding side before bringing this back.

r? @staktrace

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2786)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request May 29, 2018
@bors-servo
Auto merge of #2786 - kvark:no-debug, r=staktrace,gw3583
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d11b601 
Revert "Debug tracking of display items"

This reverts #2725, which causes chaos and destruction in Gecko tests: https://treeherder.mozilla.org/#/jobs?repo=try&revision=12a0fba7254666c7dfba9f4b738093e076de2381&selectedJob=180600645

I'll make sure to test the Gecko binding side before bringing this back.

r? @staktrace

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2786)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request May 29, 2018
@bors-servo
Auto merge of #2786 - kvark:no-debug, r=staktrace,gw3583
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d74c2e5 
Revert "Debug tracking of display items"

This reverts #2725, which causes chaos and destruction in Gecko tests: https://treeherder.mozilla.org/#/jobs?repo=try&revision=12a0fba7254666c7dfba9f4b738093e076de2381&selectedJob=180600645

I'll make sure to test the Gecko binding side before bringing this back.

r? @staktrace

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2786)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request May 29, 2018
@bors-servo
Auto merge of #2786 - kvark:no-debug, r=staktrace,gw3583
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e68fe06 
Revert "Debug tracking of display items"

This reverts #2725, which causes chaos and destruction in Gecko tests: https://treeherder.mozilla.org/#/jobs?repo=try&revision=12a0fba7254666c7dfba9f4b738093e076de2381&selectedJob=180600645

I'll make sure to test the Gecko binding side before bringing this back.

r? @staktrace

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2786)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request May 29, 2018
@bors-servo
Auto merge of #2786 - kvark:no-debug, r=staktrace
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3c2e4d4 
Revert "Debug tracking of display items"

This reverts #2725, which causes chaos and destruction in Gecko tests: https://treeherder.mozilla.org/#/jobs?repo=try&revision=12a0fba7254666c7dfba9f4b738093e076de2381&selectedJob=180600645

I'll make sure to test the Gecko binding side before bringing this back.

r? @staktrace

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2786)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request May 29, 2018
@bors-servo
Auto merge of #2786 - kvark:no-debug, r=staktrace
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
60f8034 
Revert "Debug tracking of display items"

This reverts #2725, which causes chaos and destruction in Gecko tests: https://treeherder.mozilla.org/#/jobs?repo=try&revision=12a0fba7254666c7dfba9f4b738093e076de2381&selectedJob=180600645

I'll make sure to test the Gecko binding side before bringing this back.

r? @staktrace

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2786)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request May 29, 2018
@bors-servo
Auto merge of #2786 - kvark:no-debug, r=staktrace
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0d753e6 
Revert "Debug tracking of display items"

This reverts #2725, which causes chaos and destruction in Gecko tests: https://treeherder.mozilla.org/#/jobs?repo=try&revision=12a0fba7254666c7dfba9f4b738093e076de2381&selectedJob=180600645

I'll make sure to test the Gecko binding side before bringing this back.

r? @staktrace

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2786)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennw glennw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@kvark @glennw @gw3583 @bors-servo
You can’t perform that action at this time.