Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFall back to RGBA format when BGRA isn't supported by GLES. #2731
Conversation
|
Based on this conversation with @glennw (and this note). The supported formats in the emulator include the list at https://android.googlesource.com/platform/external/qemu/+/emu-2.7-release/android/android-emugl/host/libs/Translator/GLES_V2/GLESv2Validate.cpp#20 and the list at https://android.googlesource.com/platform/external/qemu/+/emu-2.7-release/android/android-emugl/host/libs/Translator/GLES_V2/GLESv2Validate.cpp#508. |
|
@bors-servo r+ |
|
@bors-servo r=kvark |
|
|
bors-servo
added a commit
that referenced
this pull request
May 4, 2018
Fall back to RGBA format when BGRA isn't supported by GLES. This makes Servo builds run and display content in the Android emulator. The colours are incorrectly swapped as one might expect; I'm less clear on how to actually swap the underlying texture bytes to match the reported format. Fixes servo/servo#20476. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2731) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedMay 4, 2018
•
edited by larsbergstrom
This makes Servo builds run and display content in the Android emulator. The colours are incorrectly swapped as one might expect; I'm less clear on how to actually swap the underlying texture bytes to match the reported format. Fixes servo/servo#20476.
This change is