Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upExpand viewports to consist of a rectangle and a transform. #274
Conversation
Further work should expand this to an entire rectangle/transform stack, but this is an improvement over the current situation. This was necessary to properly handle clipping in the presence of nested iframes and `overflow: scroll` stacking contexts, while simultaneously handling transformed and clipped iframes. We still have some clipping issues when `overflow: scroll`, iframes, and transforms are all nested together: this is visible in the browser.html tab change animation on duckduckgo.com result pages. I wanted to get this in now, though, because this significantly improves the current situation. Addresses servo/servo#11150. Addresses servo/servo#11151.
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
May 23, 2016
Expand viewports to consist of a rectangle and a transform. Further work should expand this to an entire rectangle/transform stack, but this is an improvement over the current situation. This was necessary to properly handle clipping in the presence of nested iframes and `overflow: scroll` stacking contexts, while simultaneously handling transformed and clipped iframes. We still have some clipping issues when `overflow: scroll`, iframes, and transforms are all nested together: this is visible in the browser.html tab change animation on duckduckgo.com result pages. I wanted to get this in now, though, because this significantly improves the current situation. Addresses servo/servo#11150. Addresses servo/servo#11151. r? @glennw
|
|
|
@bors-servo: retry |
bors-servo
added a commit
that referenced
this pull request
May 23, 2016
Expand viewports to consist of a rectangle and a transform. Further work should expand this to an entire rectangle/transform stack, but this is an improvement over the current situation. This was necessary to properly handle clipping in the presence of nested iframes and `overflow: scroll` stacking contexts, while simultaneously handling transformed and clipped iframes. We still have some clipping issues when `overflow: scroll`, iframes, and transforms are all nested together: this is visible in the browser.html tab change animation on duckduckgo.com result pages. I wanted to get this in now, though, because this significantly improves the current situation. Addresses servo/servo#11150. Addresses servo/servo#11151. r? @glennw
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pcwalton commentedMay 20, 2016
Further work should expand this to an entire rectangle/transform stack,
but this is an improvement over the current situation.
This was necessary to properly handle clipping in the presence of
nested iframes and
overflow: scrollstacking contexts, whilesimultaneously handling transformed and clipped iframes.
We still have some clipping issues when
overflow: scroll, iframes, andtransforms are all nested together: this is visible in the browser.html
tab change animation on duckduckgo.com result pages. I wanted to get
this in now, though, because this significantly improves the current
situation.
Addresses servo/servo#11150.
Addresses servo/servo#11151.
r? @glennw