Skip to content

/ webrender

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update serde to 1.0.58 + serde-rs/serde#1278 #2777

Merged
merged 1 commit into from May 25, 2018
Merged

Update serde to 1.0.58 + serde-rs/serde#1278 #2777

merged 1 commit into from May 25, 2018

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented May 24, 2018 •
edited by larsbergstrom

This change is Reviewable
@SimonSapin
Update serde to 1.0.58 + serde-rs/serde#1278
Loading status checks…
7966184
@gw3583
Copy link
Collaborator

gw3583 commented May 24, 2018

r? @gankro
@Gankra
Copy link
Contributor

Gankra commented May 24, 2018

I thought we weren't supposed to update serde due to some knock on dependency effects? Was that resolved?
@Eijebong
Copy link
Member

Eijebong commented May 24, 2018

@gankro The problem was depending to the latest serde_derive which depends on syn 0.14. (Not that it really matters now that we finally removed syn 0.11 (🎉) from the dependency tree, but having three versions was a bit much)
@SimonSapin
Copy link
Member Author

SimonSapin commented May 24, 2018

serde-rs/serde#1278 and servo/deserialize_from_enums7 are based on 1.0.58 rather than .59 or upstream/master to avoid picking up syn 0.14 yet.
@Gankra
Copy link
Contributor

Gankra commented May 25, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 25, 2018

📌 Commit 7966184 has been approved by Gankro
@bors-servo
Copy link
Contributor

bors-servo commented May 25, 2018

⌛ Testing commit 7966184 with merge 60f4177...
bors-servo added a commit that referenced this pull request May 25, 2018
@bors-servo
Auto merge of #2777 - servo:serdeup, r=Gankro
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
60f4177 
Update serde to 1.0.58 + serde-rs/serde#1278

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2777)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 25, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: Gankro
Pushing 60f4177 to master...
@bors-servo bors-servo merged commit 7966184 into master May 25, 2018
6 checks passed
6 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
Taskcluster (push) TaskGroup: success
Details
Tidelift Dependencies checked
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request May 25, 2018
Merged
@SimonSapin SimonSapin deleted the serdeup branch May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@SimonSapin @gw3583 @Gankra @Eijebong @bors-servo
You can’t perform that action at this time.