Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port dot/dash to border brushes, remove old border code. #2795

Merged
merged 3 commits into from Jun 4, 2018

Commits on Jun 1, 2018

  1. Port dot/dash to border brushes, remove old border code.

    This ports the last remaining legacy border styles to run with
    the new border brush implementation.
    
    With the complete, it's possible to remove all the old border
    path code and shaders.
    
    The dash/dot placement is not quite the same as the previous
    code. It's better in some cases, and worse in others. Working
    on this as a follow up to handle all the possible edge cases
    should be much easier once this patch lands.
    
    This completes the work of moving borders to be brush images,
    which gives some very significant performance wins - mostly
    stemming from (a) caching of border primitives across scrolls
    and display lists and (b) much better batching during the main
    scene pass, since all borders are now batched as brush_images.
    gw3583 committed Jun 1, 2018
  2. Tweak the positioning of dots / dashes.

    gw3583 committed Jun 1, 2018

Commits on Jun 3, 2018

  1. Address review comments.

    gw3583 committed Jun 3, 2018
You can’t perform that action at this time.