Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImprove clipping documentation #2806
Merged
+53
−97
Conversation
|
r? @nical or anyone |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jun 5, 2018
Improve clipping documentation The old documentation was very out of date. The new documentation is slightly less complete, but should be much more accurate. This is part of #2666. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2806) <!-- Reviewable:end -->
|
|
| # Clipping and Positioning in WebRender | ||
|
|
||
| Each non-structural WebRender display list item has | ||
| * A `ClipId` of a positioning node |
This comment has been minimized.
This comment has been minimized.
kvark
Jun 5, 2018
Member
isn't it a little weird that the positioning node is defined by ClipId which has nothing to do with clipping?
This comment has been minimized.
This comment has been minimized.
mrobinson
Jun 5, 2018
Author
Member
It certainly is. I think if we do switch to using two different ids, it makes sense to call one ClipScrollNodeId and ClipChainId or something like that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mrobinson commentedJun 5, 2018
•
edited by larsbergstrom
The old documentation was very out of date. The new documentation
is slightly less complete, but should be much more accurate.
This is part of #2666.
This change is