Skip to content

/ webrender

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove arrays from vertex output #2826

Merged
merged 1 commit into from Jun 19, 2018
Merged

Remove arrays from vertex output #2826

merged 1 commit into from Jun 19, 2018
+29 −17

Conversation

@dati91
Copy link
Contributor

dati91 commented Jun 18, 2018 •
edited by larsbergstrom

We are trying to generate metal shader with spirv_cross and hitting and error:

"The vertex function output structure may not include a matrix or array."

cc @kvark @gw3583

This change is Reviewable
@dati91
Remove arrays from vertex output
Loading status checks…
e4a52d9
@dati91 dati91 mentioned this pull request Jun 18, 2018
Closed
@gw3583
Copy link
Collaborator

gw3583 commented Jun 18, 2018

@dati91 Looks good, thanks. Could you add an entry to https://github.com/servo/webrender/wiki/Driver-issues describing this issue?

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jun 18, 2018

📌 Commit e4a52d9 has been approved by gw3583
@bors-servo
Copy link
Contributor

bors-servo commented Jun 18, 2018

⌛ Testing commit e4a52d9 with merge 3a6374a...
bors-servo added a commit that referenced this pull request Jun 18, 2018
@bors-servo
Auto merge of #2826 - dati91:varying_array, r=gw3583
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3a6374a 
Remove arrays from vertex output

We are trying to generate metal shader with `spirv_cross` and hitting and error:
```
"The vertex function output structure may not include a matrix or array."
```

cc @kvark @gw3583

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2826)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 19, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: gw3583
Pushing 3a6374a to master...
@bors-servo bors-servo merged commit e4a52d9 into servo:master Jun 19, 2018
3 checks passed
3 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@dati91
Copy link
Contributor Author

dati91 commented Jun 19, 2018

@gw3583 done: https://github.com/servo/webrender/wiki/Driver-issues#2826-varying-arrays
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@dati91 @gw3583 @bors-servo
You can’t perform that action at this time.