Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use WS_EX_NOREDIRECTIONBITMAP direct-composition app #2838

Closed
wants to merge 10 commits into from

Conversation

@ekicyou
Copy link
Contributor

ekicyou commented Jun 22, 2018

[with_no_redirection_bitmap] API added to master branch of [winit].

It is useful for direct-composition samples.


This change is Reviewable

use with_no_redirection_bitmap.
api update.
@ekicyou
Copy link
Contributor Author

ekicyou commented Jun 22, 2018

There is a version mismatch of winapi, and appveyor does not pass.
Because it is difficult to solve, PR will be done as it is.

…ure/WS_EX_NOREDIRECTIONBITMAP
@atouchet
Copy link
Contributor

atouchet commented Jun 26, 2018

For what it's worth winit 0.16 is now out which includes WS_EX_NOREDIRECTIONBITMAP.

ekicyou added 2 commits Jun 26, 2018
@ekicyou
Copy link
Contributor Author

ekicyou commented Jun 26, 2018

Thanks. Changed winit.

@kvark
Copy link
Member

kvark commented Jun 28, 2018

There are legitimate CI errors that need to be addressed before we move this forward.

ekicyou added 4 commits Jun 28, 2018
This reverts commit 2f5d060.
@ekicyou
Copy link
Contributor Author

ekicyou commented Jun 29, 2018

  1. It seems that the build of winit = "0.16" does not pass in AppVeyor environment.
    still checking...
error: use of unstable library feature 'refcell_replace_swap' (see issue #43570)
   --> C:\Users\appveyor\.cargo\registry\src\github.com-1ecc6299db9ec823\winit-0.16.0\src\platform\windows\window.rs:639:25
    |
639 |         self.fullscreen.replace(monitor);
    |                         ^^^^^^^
error: aborting due to previous error
error: Could not compile `winit`.
Caused by:
  process didn't exit successfully: 
  1. To use winit = "0.16", winapi = "0.3.5" is required.
    However, this specification is keeping up with the conflict check in the Taskcluster environment.
    I would like to give some advice.
@ekicyou
Copy link
Contributor Author

ekicyou commented Jun 29, 2018

In order to use winit = "0.16.0" you need rust = "1.24.0",
but in AppVeyor environment rust = "1.23.0" is used.

#[inline]
#[stable(feature = "refcell_replace", since="1.24.0")]
pub fn replace(&self, t: T) -> T {
    mem::replace(&mut *self.borrow_mut(), t)
}
Start-FileDownload "https://static.rust-lang.org/dist/rust-1.23.0-${env:TARGET}.msi"
Downloading rust-1.23.0-x86_64-pc-windows-msvc.msi (111,887,897 bytes)...100%
msiexec /passive /i "rust-1.23.0-%TARGET%.msi" ADDLOCAL=Rustc,Cargo,Std INSTALLDIR=C:\Rust
rustc -V
rustc 1.23.0 (766bd11c8 2018-01-01)

Since we can not judge the build environment update, we suspend it as it is.

@kvark
Copy link
Member

kvark commented Jun 29, 2018

According to https://wiki.mozilla.org/Rust_Update_Policy_for_Firefox, we should be safe bumping all CIs to use Rust 1.26. Let's just do this in a separate PR.

ekicyou added 2 commits Jun 29, 2018
…ure/WS_EX_NOREDIRECTIONBITMAP
…ure/WS_EX_NOREDIRECTIONBITMAP
@ekicyou
Copy link
Contributor Author

ekicyou commented Jul 2, 2018

Thanks for the suggestion.
Since July 5 it seems that Rust 1.27.0 can be used, so please wait a while.

However, the task of unifying "winapi = 0.3.5" appears complicated.
I am sorry but I do not have the motivation to grasp the "webrender" body, which is difficult.

I think that it may be necessary to separate PR.

  • winit = "0.16.0" update
    • rust 1.27.0 update
    • winapi = "0.3.5" update
  • use WS_EX_NOREDIRECTIONBITMAP
@ekicyou ekicyou mentioned this pull request Jul 6, 2018
@ekicyou
Copy link
Contributor Author

ekicyou commented Jul 6, 2018

fnn... Update https://wiki.mozilla.org/Rust_Update_Policy_for_Firefox.
Check with PR # 2870.

@ekicyou
Copy link
Contributor Author

ekicyou commented Jul 9, 2018

This PR has more steps than expected, and an unreleased rustc1.28.0-stable is required.

Judge it as premature, close PR once.
Thank you for your advice.

@ekicyou ekicyou closed this Jul 9, 2018
@ekicyou ekicyou mentioned this pull request Jul 9, 2018
@ekicyou ekicyou deleted the ekicyou:feature/WS_EX_NOREDIRECTIONBITMAP branch Jul 11, 2018
bors-servo added a commit that referenced this pull request Jul 13, 2018
…monSapin

use WS_EX_NOREDIRECTIONBITMAP direct-composition app

`with_no_redirection_bitmap` API added to master branch of `winit=0.16.0`.
It is useful for direct-composition samples.

resubmit #2838 PR,
Thanks! #2878, #2877.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2886)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.