Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inset box shadow fixes #285

Merged
merged 3 commits into from Jun 9, 2016
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Don't draw inset box shadow edges when blur radius is 0

The box shadow shader will produce the wrong result in that case, and
there is actually no edges to fill.
  • Loading branch information
anderco committed Jun 7, 2016
commit 6c79240fedcabd485a3b4763f17401c2061f2295
@@ -819,6 +819,10 @@ impl<'a> BatchBuilder<'a> {
border_radius,
clip_mode);

if clip_mode == BoxShadowClipMode::Inset && blur_radius == 0.0 {
return;
}

// Draw the sides.
//
// +--+------------------+--+
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.