Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around OSX/Intel shader bug with integer comparison #2864

Merged
merged 1 commit into from Jul 4, 2018

Conversation

@kvark
Copy link
Member

kvark commented Jul 3, 2018

Fixes #2862
Fixes #2754

Oh OSX GL drivers, so rough, such cruel, no remorse.
r? anyone


This change is Reviewable

@pcwalton
Copy link
Collaborator

pcwalton commented Jul 3, 2018

Needs a comment explaining what's going on and linking to the issues.

@Darkspirit
Copy link

Darkspirit commented Jul 3, 2018

This will also fix bug 1423087, right?

@kvark
Copy link
Member Author

kvark commented Jul 4, 2018

@Darkspirit yes, sounds like it:

x86_64
Mac OS X

@pcwalton r?

@nical
Copy link
Collaborator

nical commented Jul 4, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Jul 4, 2018

📌 Commit e81c498 has been approved by nical

@bors-servo
Copy link
Contributor

bors-servo commented Jul 4, 2018

Testing commit e81c498 with merge 686eca6...

bors-servo added a commit that referenced this pull request Jul 4, 2018
Work around OSX/Intel shader bug with integer comparison

Fixes #2862
Fixes #2754

Oh OSX GL drivers, so rough, such cruel, no remorse.
r? anyone

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2864)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 4, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: nical
Pushing 686eca6 to master...

@bors-servo bors-servo merged commit e81c498 into servo:master Jul 4, 2018
3 checks passed
3 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@kvark kvark deleted the kvark:osx-intel-comparison branch Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.