Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate angle shader validation features and add a missing newline #2873
Conversation
|
This is blocked until we figure out the exact situation happening in #2872 |
zakorgy
changed the title
| @@ -43,7 +44,7 @@ const SHADERS: &[Shader] = &[ | |||
| // Cache shaders | |||
| Shader { | |||
| name: "cs_blur", | |||
| features: CACHE_FEATURES, | |||
| features: &[ "ALPHA_TARGET", "COLOR_TARGET" ], | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
zakorgy
Jul 6, 2018
Author
Contributor
No, because it is a LazilyCompiledShader and has no features at all: https://github.com/servo/webrender/blob/master/webrender/src/shade.rs#L629
These two are specified explicitly:
https://github.com/servo/webrender/blob/master/webrender/src/shade.rs#L501
https://github.com/servo/webrender/blob/master/webrender/src/shade.rs#L509
| }, | ||
| Shader { | ||
| name: "brush_radial_gradient", | ||
| features: &[ "DITHERING" ], | ||
| features: &[ "", "DITHERING", "ALPHA_PASS", "DITHERING,ALPHA_PASS" ], |
This comment has been minimized.
This comment has been minimized.
| }, | ||
| Shader { | ||
| name: "brush_linear_gradient", | ||
| features: &[], | ||
| features: &[ "", "DITHERING", "ALPHA_PASS", "DITHERING,ALPHA_PASS" ], |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
zakorgy
Jul 6, 2018
Author
Contributor
I just tought it is a good idea to test both gradient tests with all the possible features.
This comment has been minimized.
This comment has been minimized.
kvark
Jul 6, 2018
Member
yeah, if the dithering is indeed used, we should test for it :) let's just have a common define for those feature sets
|
Strongly related to #2436 |
…dation, and update shader features
|
@kvark Could you please take a look at this PR? I think, I have addressed all of your comments. |
|
Yes, thank you! |
|
@bors-servo r+ |
|
|
Update angle shader validation features and add a missing newline This adds the missing new line to the end of the the feature strings, which I described in #2872. Also updated the features which the angle validator uses for testing, since `TRANSFORM` is no longer a Primitive shader feature and Brush shaders have their own feature set too. Fixes #2872 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2873) <!-- Reviewable:end -->
|
|
zakorgy commentedJul 6, 2018
•
edited by kvark
This adds the missing new line to the end of the the feature strings, which I described in #2872.
Also updated the features which the angle validator uses for testing, since
TRANSFORMis no longer a Primitive shader feature and Brush shaders have their own feature set too.Fixes #2872
This change is