Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate dependencies #2878
Update dependencies #2878
Conversation
| @@ -259,7 +260,7 @@ fn make_window( | |||
| let window_builder = winit::WindowBuilder::new() | |||
| .with_title("WRench") | |||
| .with_multitouch() | |||
| .with_dimensions(size.width, size.height); | |||
| .with_dimensions(glutin::dpi::LogicalSize::new(size.width as f64, size.height as f64)); | |||
This comment has been minimized.
This comment has been minimized.
| @@ -171,10 +172,10 @@ impl Window { | |||
| } | |||
|
|
|||
| let framebuffer_size = { | |||
| let (width, height) = self.window.get_inner_size().unwrap(); | |||
| DeviceUintSize::new(width, height) | |||
| let glutin::dpi::LogicalSize {width, height} = self.window.get_inner_size().unwrap(); | |||
This comment has been minimized.
This comment has been minimized.
|
Failure is legit on both. I'd need help updating the rust version on taskcluster though |
|
Right now all the taskcluster failures are just linting problems. But I can help with updating rust versions - what version of rust do you want to be running on? |
|
Mhh maybe it's not necessary then, 1.25 seems to be working but if we can get to the same version as firefox it'd be nice :) |
|
The linux runs in the taskcluster CI always update rust to the latest stable version (so should be 1.27 now). The mac runs do not, but I manually updated that to 1.27 as well sometime last week. So everything in taskcluster CI should be using 1.27. |
|
Oh ok, nice ! |
Eijebong
force-pushed the
Eijebong:bump-stuff
branch
8 times, most recently
from
3437087
to
781dd42
Including glutin, winit, core-* stuff.
|
@bors-servo r+ |
|
|
Update dependencies Including glutin, winit, core-* stuff. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2878) <!-- Reviewable:end -->
|
|
…monSapin use WS_EX_NOREDIRECTIONBITMAP direct-composition app `with_no_redirection_bitmap` API added to master branch of `winit=0.16.0`. It is useful for direct-composition samples. resubmit #2838 PR, Thanks! #2878, #2877. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2886) <!-- Reviewable:end -->
Eijebong commentedJul 10, 2018
•
edited by larsbergstrom
Including glutin, winit, core-* stuff.
This change is