Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert some ClipScrollNodeIndex references to TransformIndex. #2879

Closed
wants to merge 1 commit into from

Conversation

@gw3583
Copy link
Collaborator

gw3583 commented Jul 10, 2018

This is some more prep work for supporting rasterizing Pictures
in different coordinate spaces.

Other minor changes:

  • Rename TransformPaletteId to TransformId.
  • Modify reftest to force an off-screen target, since the
    opacity filter was being collapsed due to opacity optimizations.

This change is Reviewable

This is some more prep work for supporting rasterizing Pictures
in different coordinate spaces.

Other minor changes:
 - Rename TransformPaletteId to TransformId.
 - Modify reftest to force an off-screen target, since the
   opacity filter was being collapsed due to opacity optimizations.
@gw3583
Copy link
Collaborator Author

gw3583 commented Jul 10, 2018

r? @kvark or @mrobinson

We can hold off on merging this if it's going to conflict with the clip-scroll-tree splitting work.

Pending try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a0b8acb0c5b631c52c2d6f1bd7c76c61799637af

Pending baseline try of Gecko + WR master:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b0f06c13975e8c13c08ea28d5c6f9f4964a979b1

@bors-servo
Copy link
Contributor

bors-servo commented Jul 10, 2018

The latest upstream changes (presumably #2871) made this pull request unmergeable. Please resolve the merge conflicts.

@gw3583
Copy link
Collaborator Author

gw3583 commented Jul 10, 2018

Some assumptions here will need to change with the clip-scroll tree split PR. I'll close this and re-open once this is refactored.

@gw3583 gw3583 closed this Jul 10, 2018
@gw3583 gw3583 deleted the gw3583:local-stuff-2 branch Jul 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.