Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upBump euclid and plane-split. #2882
Conversation
|
I notice that only examples, webrender, webrender_api, and wrench are used in Gecko, and webrender_bindings are not in this repo (which is in Gecko, I guess). That's why I didn't update euclid for pathfinder. |
|
r? @nical |
|
OK.. taskclaster said I have to update euclid for pathfinder and lyon_geom. |
|
@BorisChiou ouch I'm sorry you are going through all of this for a non-breaking change. the latest version of lyon_geom already depends on euclid 0.18.0 so if you update pathfinder to that version it should be good (pathfinder being the only crate that depends on lyon_geom). Hopefully the things in lyon_geom that pathfinder use haven't changed too much since the version pathfinder is using. Let me know if you run into issues updating it (I maintain lyon_geom). |
|
|
We bump euclid for direct-composition, examples, webrender, webrender_api, and wrench. Also, bump plane-split so we could drop the old version of euclid.
|
OK, let's try again |
|
r? @nical |
|
|
|
@BorisChiou This is superseded by #2904 |
|
It's ok. I will close this. Thanks for bumping the version. :) |
BorisChiou commentedJul 10, 2018
•
edited by larsbergstrom
We bump euclid for direct-composition, examples, webrender,
webrender_api, and wrench.
This change is