Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use WS_EX_NOREDIRECTIONBITMAP direct-composition app #2886

Merged
merged 1 commit into from Jul 13, 2018

Conversation

@ekicyou
Copy link
Contributor

ekicyou commented Jul 12, 2018

with_no_redirection_bitmap API added to master branch of winit=0.16.0.
It is useful for direct-composition samples.

resubmit #2838 PR,
Thanks! #2878, #2877.


This change is Reviewable

@kvark kvark requested a review from SimonSapin Jul 13, 2018
@SimonSapin
Copy link
Member

SimonSapin commented Jul 13, 2018

Looks good, thanks!

@bors-servo r+

I didn’t know what WS_EX_NOREDIRECTIONBITMAP is, and https://docs.microsoft.com/en-us/windows/desktop/winmsg/extended-window-styles was not super informative. https://stackoverflow.com/questions/38179033/when-should-ws-ex-noredirectionbitmap-be-used and https://msdn.microsoft.com/magazine/dn745861.aspx have a better explanation. (That last article would have been useful to find while figuring out how to use DirectComposition to make this demo!)

For posterity, this is what the demo app looks like now (with in the background the terminal where I compiled it).
capture3

@bors-servo
Copy link
Contributor

bors-servo commented Jul 13, 2018

📌 Commit d7ef6a2 has been approved by SimonSapin

@bors-servo
Copy link
Contributor

bors-servo commented Jul 13, 2018

Testing commit d7ef6a2 with merge c540acf...

bors-servo added a commit that referenced this pull request Jul 13, 2018
…monSapin

use WS_EX_NOREDIRECTIONBITMAP direct-composition app

`with_no_redirection_bitmap` API added to master branch of `winit=0.16.0`.
It is useful for direct-composition samples.

resubmit #2838 PR,
Thanks! #2878, #2877.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2886)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 13, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: SimonSapin
Pushing c540acf to master...

@bors-servo bors-servo merged commit d7ef6a2 into servo:master Jul 13, 2018
3 checks passed
3 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@ekicyou
Copy link
Contributor Author

ekicyou commented Jul 13, 2018

Thank you for adding explanation.
Although commit is dare to mention .with_decorations(true),When false, the world without windows spreads.

Even though it is Windows :-)

By using WS_EX_NOREDIRECTIONBITMAP and DirectComposition, you can develop applications without windows by GPU rendering (2D / 3D) (such as desktop mascot).

@ekicyou ekicyou deleted the ekicyou:feature/WS_EX_NOREDIRECTIONBITMAP branch Sep 13, 2018
@ekicyou ekicyou restored the ekicyou:feature/WS_EX_NOREDIRECTIONBITMAP branch Sep 13, 2018
@ekicyou ekicyou deleted the ekicyou:feature/WS_EX_NOREDIRECTIONBITMAP branch Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.