Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix fps counter #2889
Merged
Fix fps counter #2889
Conversation
|
Oh boy. |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 12, 2018
Fix fps counter Address #2887. Current FPS counter count calls of render_impl()s. But we normally expects frame generation counts. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2889) <!-- Reviewable:end -->
|
|
|
@sotaroikeda FYI, github recognizes some of the words like "Fixes xxx" or "Closes xxx", so if you used those instead of "Address xxx", it would automatically close the issue upon merging a PR, which is considered a good practice. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
sotaroikeda commentedJul 12, 2018
•
edited by larsbergstrom
Address #2887.
Current FPS counter count calls of render_impl()s. But we normally expects frame generation counts.
This change is