Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upallow custom gamma and contrast for DWrite fonts #2896
Conversation
| } | ||
|
|
||
| #[cfg(target_os = "windows")] | ||
| impl Default for FontInstancePlatformOptions { | ||
| fn default() -> FontInstancePlatformOptions { | ||
| FontInstancePlatformOptions { | ||
| unused: 0, | ||
| gamma: 220, |
This comment has been minimized.
This comment has been minimized.
gw3583
Jul 16, 2018
Collaborator
The previous default constant used was 230 - is 220 correct? Also, could we add a comment here describing why this is the default?
|
Just one minor comment - otherwise looks good! |
webrender_api/src/font.rs, line 279 at r1 (raw file): Previously, gw3583 (Glenn Watson) wrote…
It was 1.8 (=180), so for now I just put it back at 180. But the Gecko default in many places when no value is specified can also be 2.2 (=220). It's kind of arguable which one to use, since neither is really right as a fixed value. I just put it back to 180 for now since that is what it was before. |
|
@bors-servo r+ |
|
|
allow custom gamma and contrast for DWrite fonts This is to resolve Gecko bug https://bugzilla.mozilla.org/show_bug.cgi?id=1474968 This passes in gamma and contrast so we can parameterize preblending more closely to how Skia is doing so in Gecko. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2896) <!-- Reviewable:end -->
|
|
lsalzman commentedJul 16, 2018
•
edited by larsbergstrom
This is to resolve Gecko bug https://bugzilla.mozilla.org/show_bug.cgi?id=1474968
This passes in gamma and contrast so we can parameterize preblending more closely to how Skia is doing so in Gecko.
This change is