Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upPush an empty hit testing clip node for empty ClipNodes #2899
Conversation
Some Gecko display lists produce out-of-sequence ClipIds for ClipNodes (#2898) which leads to empty ClipNodes. Previously the HitTester was just discarding those nodes. This is an obvious problem because it means that subsequent ClipNodeIndices are out-of-sync with the HitTester's list of clipping nodes. This change fixes this by also adding empty clipping nodes in the HitTester. Unfortunately, we can't make a test for this until we figure out how and why Gecko is producing display lists with out-of-sequence ClipIds. Hopefully once we do that, we will no longer need to create empty HitTester nodes at all.
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 16, 2018
…vark Push an empty hit testing clip node for empty ClipNodes Some Gecko display lists produce out-of-sequence ClipIds for ClipNodes (#2898) which leads to empty ClipNodes. Previously the HitTester was just discarding those nodes. This is an obvious problem because it means that subsequent ClipNodeIndices are out-of-sync with the HitTester's list of clipping nodes. This change fixes this by also adding empty clipping nodes in the HitTester. Unfortunately, we can't make a test for this until we figure out how and why Gecko is producing display lists with out-of-sequence ClipIds. Hopefully once we do that, we will no longer need to create empty HitTester nodes at all. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2899) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mrobinson commentedJul 16, 2018
•
edited by larsbergstrom
Some Gecko display lists produce out-of-sequence ClipIds for ClipNodes
(#2898) which leads to empty ClipNodes. Previously the HitTester was
just discarding those nodes. This is an obvious problem because it means
that subsequent ClipNodeIndices are out-of-sync with the HitTester's
list of clipping nodes. This change fixes this by also adding empty
clipping nodes in the HitTester.
Unfortunately, we can't make a test for this until we figure out how and
why Gecko is producing display lists with out-of-sequence ClipIds.
Hopefully once we do that, we will no longer need to create empty
HitTester nodes at all.
This change is