Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push an empty hit testing clip node for empty ClipNodes #2899

Merged
merged 1 commit into from Jul 16, 2018

Commits on Jul 16, 2018

  1. Push an empty hit testing clip node for empty ClipNodes

    Some Gecko display lists produce out-of-sequence ClipIds for ClipNodes
    (#2898) which leads to empty ClipNodes. Previously the HitTester was
    just discarding those nodes. This is an obvious problem because it means
    that subsequent ClipNodeIndices are out-of-sync with the HitTester's
    list of clipping nodes. This change fixes this by also adding empty
    clipping nodes in the HitTester.
    
    Unfortunately, we can't make a test for this until we figure out how and
    why Gecko is producing display lists with out-of-sequence ClipIds.
    Hopefully once we do that, we will no longer need to create empty
    HitTester nodes at all.
    mrobinson committed Jul 16, 2018
You can’t perform that action at this time.