Skip to content

/ webrender

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update euclid to 0.18 #2904

Merged
merged 2 commits into from Jul 18, 2018
Merged

Update euclid to 0.18 #2904

merged 2 commits into from Jul 18, 2018

Conversation

@Eijebong
Copy link
Member

Eijebong commented Jul 17, 2018 •
edited by larsbergstrom

This change is Reviewable
@nical
Copy link
Collaborator

nical commented Jul 17, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jul 17, 2018

📌 Commit df39451 has been approved by nical
@Eijebong
Update euclid to 0.18
Loading status checks…
2a6676d
@Eijebong Eijebong force-pushed the Eijebong:euclid branch from df39451 to 2a6676d Jul 17, 2018
@nical
Copy link
Collaborator

nical commented Jul 17, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jul 17, 2018

📌 Commit 2a6676d has been approved by nical
@Eijebong
Bump rust's version to fix tests
Loading status checks…
2903357
@nical
Copy link
Collaborator

nical commented Jul 17, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jul 17, 2018

📌 Commit 2903357 has been approved by nical
@Eijebong Eijebong mentioned this pull request Jul 17, 2018
Closed
@bors-servo
Copy link
Contributor

bors-servo commented Jul 18, 2018

⌛ Testing commit 2903357 with merge 9117f29...
bors-servo added a commit that referenced this pull request Jul 18, 2018
@bors-servo
Auto merge of #2904 - Eijebong:euclid, r=nical
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9117f29 
Update euclid to 0.18

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2904)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 18, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: nical
Pushing 9117f29 to master...
@bors-servo bors-servo merged commit 2903357 into servo:master Jul 18, 2018
3 checks passed
3 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@staktrace
Copy link
Contributor

staktrace commented Jul 18, 2018

This PR seems to have caused some panics in Firefox CI, see https://bugzilla.mozilla.org/show_bug.cgi?id=1476636#c1
@staktrace
Copy link
Contributor

staktrace commented Jul 18, 2018

Here's a sample log: https://treeherder.mozilla.org/logviewer.html#?job_id=188772693&repo=try&lineNumber=1438
@nical
Copy link
Collaborator

nical commented Jul 18, 2018

The panic is because this https://github.com/servo/webrender/pull/2904/files#diff-9c1d8b23da9e37ae3377086804c5aaf2L588 used to always have Some(transformed rect) and now can have None since transforming a rect is fallible in the latest euclid, since servo/euclid#291.

cc @kvark

I suppose that in this case we could cull out entirely the rects that we couldn't project.
@kvark
Copy link
Member

kvark commented Jul 18, 2018

@nical thank you for investigation! could you file an issue about the crash, and we'll get it fixed
@nical nical mentioned this pull request Jul 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Eijebong @nical @bors-servo @staktrace @kvark
You can’t perform that action at this time.