Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

euclid update #2923

Merged
merged 1 commit into from Jul 31, 2018
Merged

euclid update #2923

merged 1 commit into from Jul 31, 2018

Conversation

@paulrouget
Copy link
Collaborator

paulrouget commented Jul 21, 2018

This change is Reviewable

@Eijebong
Copy link
Member

Eijebong commented Jul 21, 2018

You also need to update the lockfile and this is blocked on nical/lyon#394

cargo update -p euclid

@paulrouget paulrouget force-pushed the paulrouget:euclid_update branch 3 times, most recently from 00a703c to 0348f9a Jul 24, 2018
@paulrouget
Copy link
Collaborator Author

paulrouget commented Jul 30, 2018

@paulrouget paulrouget force-pushed the paulrouget:euclid_update branch from 0348f9a to 8eabb14 Jul 30, 2018
@paulrouget paulrouget force-pushed the paulrouget:euclid_update branch from 8eabb14 to 8785ae6 Jul 31, 2018
@paulrouget
Copy link
Collaborator Author

paulrouget commented Jul 31, 2018

Fixed all the duplicated dependencies.

r?

@kvark
Copy link
Member

kvark commented Jul 31, 2018

I wonder why/how the euclid update works given that num-traits is still 0.1 here. Perhaps, they used the semver hack ?..

@Eijebong
Copy link
Member

Eijebong commented Jul 31, 2018

@kvark They did. That euclid update is hopefully the last one before getting rid of num-traits 0.1

@kvark
kvark approved these changes Jul 31, 2018
@kvark
Copy link
Member

kvark commented Jul 31, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Jul 31, 2018

📌 Commit 8785ae6 has been approved by kvark

@bors-servo
Copy link
Contributor

bors-servo commented Jul 31, 2018

Testing commit 8785ae6 with merge 2343e9b...

bors-servo added a commit that referenced this pull request Jul 31, 2018
euclid update

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2923)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 31, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: kvark
Pushing 2343e9b to master...

@bors-servo bors-servo merged commit 8785ae6 into servo:master Jul 31, 2018
3 checks passed
3 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
bors-servo added a commit to servo/servo that referenced this pull request Aug 6, 2018
Webrender update

Requires:

- ~winit PR: rust-windowing/winit#608
- ~glutin PR: rust-windowing/glutin#1047
- ~skia PR: servo/skia#164
- ~azure PR: servo/rust-azure#291
- ~WR PR: servo/webrender#2923
- ~offscreen gl context PR: servo/surfman#127
- ~plane-split PR: servo/plane-split#14
- ~pathfinder: https://github.com/pcwalton/pathfinder/pull/92~

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21223)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.