Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only trigger a frame build if scene properties have changed. #2927

Merged
merged 1 commit into from Jul 24, 2018

Commits on Jul 24, 2018

  1. Only trigger a frame build if scene properties have changed.

    In many important use cases (e.g. video playback on youtube) the
    display list doesn't change very often. Typically, the only
    thing changing between frames are the natively decoded video
    texture surfaces.
    
    In these cases, we can save a significant amount of CPU usage
    and battery power by not building a frame at all.
    
    Previously, any call to set/update dynamic properties would
    trigger a frame rebuild. However, it's often the case that
    Gecko sends dynamic properties updates that are either empty
    or exactly the same as the previous frame.
    
    With this change, WR will compare the scene properties and
    only trigger a frame rebuild if they have actually changed.
    
    This is a partial step towards fixing #2917 - a couple of
    other changes are also needed to completely avoid a frame
    rebuiild in this use case.
    gw3583 committed Jul 24, 2018
You can’t perform that action at this time.