Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd ClipStore struct, and use flat vec for clip sources. #2937
Conversation
We previously used a free list for clip sources, since it was possible to add/remove clip sources lists within a single display list. That's no longer used, so switch to a flat vec which is a bit simpler and slightly more efficient. Add a ClipStore struct. This currently holds clip sources only, but as we start to support clip chains in different coordinate systems, we'll move the clip chains from the CST to live here.
|
r? @kvark |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 30, 2018
Add ClipStore struct, and use flat vec for clip sources. We previously used a free list for clip sources, since it was possible to add/remove clip sources lists within a single display list. That's no longer used, so switch to a flat vec which is a bit simpler and slightly more efficient. Add a ClipStore struct. This currently holds clip sources only, but as we start to support clip chains in different coordinate systems, we'll move the clip chains from the CST to live here. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2937) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
gw3583 commentedJul 30, 2018
•
edited by larsbergstrom
We previously used a free list for clip sources, since it was
possible to add/remove clip sources lists within a single
display list. That's no longer used, so switch to a flat vec
which is a bit simpler and slightly more efficient.
Add a ClipStore struct. This currently holds clip sources only,
but as we start to support clip chains in different coordinate
systems, we'll move the clip chains from the CST to live here.
This change is