Skip to content

/ webrender

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do perspective division in hardware #2939

Merged
merged 2 commits into from Aug 1, 2018
Merged

Do perspective division in hardware #2939

merged 2 commits into from Aug 1, 2018
+74 −63

Conversation

@kvark
Copy link
Member

kvark commented Jul 30, 2018 •
edited

Fixes #2932

TODO:

This change is Reviewable
@kvark kvark requested a review from gw3583 Jul 30, 2018
@kvark kvark force-pushed the kvark:shader-transform branch from ccb1650 to dab75cf Jul 30, 2018
@gw3583
Copy link
Collaborator

gw3583 commented Jul 30, 2018

It seems like there is a lot of orange on try, is that expected? (I haven't looked at the patch in detail yet)
@kvark
Copy link
Member Author

kvark commented Jul 31, 2018

@gw3583 it looks like some snapping logic is still not correct, which I'm going to fix. Otherwise, reftest failures are expected within a reasonable threshold, given that the shader transform logic is now different.
kvark added 2 commits Jul 30, 2018
@kvark
Do perspective division in hardware
f2114f9
@kvark
Transform reftests update for the new shader semantics
Loading status checks…
fea5c87
@kvark kvark force-pushed the kvark:shader-transform branch from dab75cf to fea5c87 Jul 31, 2018
@kvark
Copy link
Member Author

kvark commented Jul 31, 2018

Snapping is fixed now. Launched a new try push in https://treeherder.mozilla.org/#/jobs?repo=try&revision=63fdc4c26c5eb7674d32aaf5649ff23215bde56e
@kvark
Copy link
Member Author

kvark commented Jul 31, 2018

@gw3583 reftests show a few intermittents but nothing wrong, as far as I can see. This should be ready to land.
@gw3583
Copy link
Collaborator

gw3583 commented Jul 31, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jul 31, 2018

📌 Commit fea5c87 has been approved by gw3583
@bors-servo
Copy link
Contributor

bors-servo commented Jul 31, 2018

⌛ Testing commit fea5c87 with merge c8f8491...
bors-servo added a commit that referenced this pull request Jul 31, 2018
@bors-servo
Auto merge of #2939 - kvark:shader-transform, r=gw3583
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c8f8491 
Do perspective division in hardware

Fixes #2932

TODO:
- [x] update reftests - commits/ccb1650afeceba1091df42f87c15babd48fb9158
- [x] run gecko try push - https://treeherder.mozilla.org/#/jobs?repo=try&revision=7c537505d671aa629232b5563d21d0c1b01ab2a6

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2939)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 1, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: gw3583
Pushing c8f8491 to master...
@bors-servo bors-servo merged commit fea5c87 into servo:master Aug 1, 2018
3 of 4 checks passed
3 of 4 checks passed
code-review/reviewable 9 files left (gw3583)
Details
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@kvark kvark deleted the kvark:shader-transform branch Aug 27, 2018
@kvark kvark mentioned this pull request Aug 28, 2018
Merged
bors-servo added a commit that referenced this pull request Aug 30, 2018
@bors-servo
Auto merge of #2991 - kvark:perspective-blend, r=gw3583
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5fa5c46 
Perspective interpolation fix for brush_blend

Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1486113
This is a follow-up to #2939

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2991)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gw3583 gw3583

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@kvark @gw3583 @bors-servo
You can’t perform that action at this time.