New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace heap allocation of clip-related objects with iteration #2943

Merged
merged 3 commits into from Aug 1, 2018

Conversation

Projects
None yet
3 participants
@kvark
Member

kvark commented Jul 31, 2018

This PR makes scene building faster by doing less heap allocations.

r? @Gankro or @gw3583
cc @gw3583 - this is a follow-up to #2925 that I figured I'd forget about if I don't do it now ;)


This change is Reviewable

@gw3583

This comment has been minimized.

Show comment
Hide comment
@gw3583
Contributor

gw3583 commented Jul 31, 2018

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Jul 31, 2018

Contributor

📌 Commit 0bbc4fa has been approved by gw3583

Contributor

bors-servo commented Jul 31, 2018

📌 Commit 0bbc4fa has been approved by gw3583

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Aug 1, 2018

Contributor

⌛️ Testing commit 0bbc4fa with merge 72e2acf...

Contributor

bors-servo commented Aug 1, 2018

⌛️ Testing commit 0bbc4fa with merge 72e2acf...

bors-servo added a commit that referenced this pull request Aug 1, 2018

Auto merge of #2943 - kvark:clip-iter, r=gw3583
Replace heap allocation of clip-related objects with iteration

This PR makes scene building faster by doing less heap allocations.

r? @Gankro or @gw3583
cc @gw3583  - this is a follow-up to #2925 that I figured I'd forget about if I don't do it now ;)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2943)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Aug 1, 2018

Contributor

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: gw3583
Pushing 72e2acf to master...

Contributor

bors-servo commented Aug 1, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: gw3583
Pushing 72e2acf to master...

@bors-servo bors-servo merged commit 0bbc4fa into servo:master Aug 1, 2018

3 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

@kvark kvark deleted the kvark:clip-iter branch Aug 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment