Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMake coordinate_system_relative_transform an offset. #2944
Merged
Conversation
coordinate_system_relative_transform can only ever be a 2d offset, so use the type system to enforce this.
|
This simplifies some of the clipping changes I'm working on. r? @kvark |
|
Good stuff! Reminds me of #2869 :) |
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 1, 2018
Make coordinate_system_relative_transform an offset. coordinate_system_relative_transform can only ever be a 2d offset, so use the type system to enforce this. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2944) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
gw3583 commentedAug 1, 2018
•
edited by larsbergstrom
coordinate_system_relative_transform can only ever be a 2d
offset, so use the type system to enforce this.
This change is