Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upProper near plane splitting #2947
Conversation
|
Wow, nice! I'll review this today. Could you kick off a try-push in the meantime? |
|
Launched a try in https://treeherder.mozilla.org/#/jobs?repo=try&revision=b1fc20bb9928bf6e3ed055fb9bb69c5250c8d784 |
|
There are several new PASS results in the try
|
|
The change basically looks good to me, but I'll take another pass over it once we get that assert failure fixed :) |
|
Addressed the try push issues in servo/plane-split#18 So far, it's a bunch of intermittents plus the expected unexpected passes. |
|
Try run looks good to me! |
|
@bors-servo r+ |
|
|
Proper near plane splitting The PR is built on the shoulders of #2913, #2741, servo/euclid#277, servo/euclid#291, servo/plane-split#12, and (last but not the least!) servo/plane-split#15 It uses the new clipping semantics in `plane-split` crate uniformly for both bounding box computation and 3d plane splitting itself, ensuring that no incorrect perspective divisions are performed (and closing quite a few TODO entries). Also adds a small reftest for the latter. Fixes #2272 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2947) <!-- Reviewable:end -->
|
|

kvark commentedAug 1, 2018
•
edited by larsbergstrom
The PR is built on the shoulders of #2913, #2741, servo/euclid#277, servo/euclid#291, servo/plane-split#12, and (last but not the least!) servo/plane-split#15
It uses the new clipping semantics in
plane-splitcrate uniformly for both bounding box computation and 3d plane splitting itself, ensuring that no incorrect perspective divisions are performed (and closing quite a few TODO entries). Also adds a small reftest for the latter.Fixes #2272
This change is