Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix the max dot/dash limit comment/constant and preallocate the container. #2949
Conversation
…iner.
|
Looks reasonable |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 2, 2018
Fix the max dot/dash limit comment/constant and preallocate the container. The comment is wrong (see #2915). I set the constant to 2k which is conservatively high, we might want to tweak it in the future (or better even, rewrite this so that the shader can render dots and dashes without requiring per-dot data). I also pre-allocated the vector to avoid reallocating over and over in the bad cases. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2949) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nical commentedAug 2, 2018
•
edited by larsbergstrom
The comment is wrong (see #2915). I set the constant to 2k which is conservatively high, we might want to tweak it in the future (or better even, rewrite this so that the shader can render dots and dashes without requiring per-dot data).
I also pre-allocated the vector to avoid reallocating over and over in the bad cases.
This change is