Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix texture upload size and track it #2950

Merged
merged 1 commit into from Aug 3, 2018

Conversation

@kvark
Copy link
Member

commented Aug 3, 2018

Fixes #2930
Also, apparently, we were uploading way more data then we needed. Say, if the client (Gecko) stores texture data in a 1GB memory buffer, and it wants to upload the left-top texel only, we'd fill up the PBO with all of that 1GB... But the good news is - this should be fixed with this PR.

TODO: gecko try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=78f3185784677b34223ed2cce9cd2358f0c93209


This change is Reviewable

@kvark kvark requested a review from gw3583 Aug 3, 2018
@gw3583

This comment has been minimized.

Copy link
Collaborator

commented Aug 3, 2018

Oh, nice find! 👍

@bors-servo r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Aug 3, 2018

📌 Commit b48e32c has been approved by gw3583

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Aug 3, 2018

⌛️ Testing commit b48e32c with merge cd50308...

bors-servo added a commit that referenced this pull request Aug 3, 2018
Fix texture upload size and track it

Fixes #2930
Also, apparently, we were uploading way more data then we needed. Say, if the client (Gecko) stores texture data in a 1GB memory buffer, and it wants to upload the left-top texel only, we'd fill up the PBO with all of that 1GB... But the good news is - this should be fixed with this PR.

~~TODO:~~ gecko try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=78f3185784677b34223ed2cce9cd2358f0c93209

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2950)
<!-- Reviewable:end -->
@gw3583
gw3583 approved these changes Aug 3, 2018
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Aug 3, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: gw3583
Pushing cd50308 to master...

@bors-servo bors-servo merged commit b48e32c into servo:master Aug 3, 2018
3 checks passed
3 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@kvark kvark deleted the kvark:tex-upload branch Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.