Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed the PicturePrimitive inside BrushPrimitive. #2961

Merged
merged 1 commit into from Aug 10, 2018

Commits on Aug 10, 2018

  1. Embed the PicturePrimitive inside BrushPrimitive.

    Remove the cpu_pictures array and store the PicturePrimitive
    directly inside the BrushPrimitive.
    
    The rationale here is to move the prim store arrays to be stored
    and owned by each PicturePrimitive. This is an interim step
    towards that - it's a bit messy in places due to borrow check
    issues, but should be a lot tidier once complete.
    
    The benefit of doing this is that as we start to cache Pictures
    more aggressively, we can retain the PicturePrimitive struct
    from a previous frame, and easily compare the embedded primitive
    runs to see if we have a cache hit.
    
    This will make it possible to cache Picture primitives between
    *display lists* rather than just scroll frames where appropriate,
    by doing a deep compare on the primitive runs in a picture.
    gw3583 committed Aug 10, 2018
You can’t perform that action at this time.