Join GitHub today
Add a debugging feature to visualize overdraw. #2963
Looks like there are some shader validation failures on CI:
It might just be related to needing to pass the right defines to the validation code, if they've changed.
gw3583 left a comment
Instead of having a separate shader, we could perhaps have just had an #ifdef in the fragment shader skeleton for brush.glsl? Doesn't really matter either way though.
We'll need to resolve the shader validation errors on CI above. If we instead added an
We should do a try run too, to make sure that nothing breaks with any of the weird shader combinations. I can do that on Monday if you're not sure how to do a gecko try.
Add a debugging feature to visualize overdraw. Lighter shades of orange indicate more overdraw. This has already helped to diagnose a few issues (e.g. #2958). r? @gw3583 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2963) <!-- Reviewable:end -->