Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upEnsure that non-local clips are defaulted to be in the clip mask. #2964
+75
−41
Conversation
If we can't calculate a local space rect for the clip, due to perspective weirdness, just assume that it should be in the clip mask, for now.
|
This fixes the issue discussed in #2951. Try run looks good now: r? @kvark |
Would be good to have some sort of an assert or at least a reminder to do that @bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 10, 2018
Ensure that non-local clips are defaulted to be in the clip mask. If we can't calculate a local space rect for the clip, due to perspective weirdness, just assume that it should be in the clip mask, for now. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2964) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
gw3583 commentedAug 10, 2018
•
edited by larsbergstrom
If we can't calculate a local space rect for the clip, due to
perspective weirdness, just assume that it should be in the
clip mask, for now.
This change is