New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent border widths to allocate huge render task surfaces. #2966

Merged
merged 1 commit into from Aug 10, 2018

Conversation

Projects
None yet
3 participants
@nical
Collaborator

nical commented Aug 10, 2018

Following up from #2956 this PR makes us scale down the the intermediate render task we use to rasterize borders if the width is larger than 2k, just like we do with border radii.


This change is Reviewable

@kvark

kvark approved these changes Aug 10, 2018

@kvark

This comment has been minimized.

Show comment
Hide comment
@kvark
Member

kvark commented Aug 10, 2018

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Aug 10, 2018

Contributor

📌 Commit c709a7c has been approved by kvark

Contributor

bors-servo commented Aug 10, 2018

📌 Commit c709a7c has been approved by kvark

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Aug 10, 2018

Contributor

⌛️ Testing commit c709a7c with merge 3d7bf71...

Contributor

bors-servo commented Aug 10, 2018

⌛️ Testing commit c709a7c with merge 3d7bf71...

bors-servo added a commit that referenced this pull request Aug 10, 2018

Auto merge of #2966 - nical:huge-border-width, r=kvark
Prevent border widths to allocate huge render task surfaces.

Following up from #2956 this PR makes us scale down the the intermediate render task we use to rasterize borders if the width is larger than 2k, just like we do with border radii.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2966)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Aug 10, 2018

Contributor

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: kvark
Pushing 3d7bf71 to master...

Contributor

bors-servo commented Aug 10, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: kvark
Pushing 3d7bf71 to master...

@bors-servo bors-servo merged commit c709a7c into servo:master Aug 10, 2018

3 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment