Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify determining if a batch can be merged / needs scissor. #2974

Merged
merged 1 commit into from Aug 16, 2018

Commits on Aug 16, 2018

  1. Simplify determining if a batch can be merged / needs scissor.

    Previously, we checked if the bounding box of any child primitives
    extended outside the rectangle of the allocated task rect. However,
    there is a simpler way to calculate this.
    
    If the allocated size of the render task is >= the unclipped size
    of the picture bounding rect, no scissor is needed, since we know
    that local clip rects will take care of ensuring nothing is
    drawn outside the task boundary.
    
    This is an optimization, but the main benefit is removing one more
    piece of code that relies on knowledge of screen / device rects,
    which simplifies the ongoing work to be able to rasterize in other
    coordinate systems.
    gw3583 committed Aug 16, 2018
You can’t perform that action at this time.