Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctness and optimizations for clips in different coord systems. #2980

Merged
merged 2 commits into from Aug 24, 2018

Commits on Aug 23, 2018

  1. Correctness and optimizations for clips in different coord systems.

    For clips that are in a different coordinate system, it's not
    generally feasible to get a correct mapping into a different
    coordinate system - so handle these clips in world space. For
    now, the world space is actually screen space. However, it is
    trivial to modify this so that the world space is the coordinate
    system that we are rasterizing this picture in.
    
    As an optimization, if we encounter a primitive that is large,
    and has clips from a different coord system, but no local clips,
    then segment it into a uniform grid. This allows large primitives
    that would not otherwise be segmented to opt in to segmenting,
    which can significantly reduce the size of the allocated clip
    masks for that primitive.
    
    As a further optimization, we are now able to generate a custom
    clip chain instance for each segment, rather than using the
    clip chain from the primitive. This allows us to build a more
    optimized clip chain, based on the segment rectangle, which can
    often remove redundant clips from the mask for each segment, or
    even determine that this segment is not affected by any clips
    at all.
    gw3583 committed Aug 23, 2018

Commits on Aug 24, 2018

  1. Address review comments.

    gw3583 committed Aug 24, 2018
You can’t perform that action at this time.