Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support shadows for Border and Image Brushes. #2984

Merged
merged 2 commits into from Aug 24, 2018

Conversation

@djg
Copy link
Contributor

commented Aug 24, 2018

Fixed #2981


This change is Reviewable

@kvark
kvark approved these changes Aug 24, 2018
top: border.top.into(),
right: border.right.into(),
bottom: border.bottom.into(),
widths: (*widths).into(),

This comment has been minimized.

Copy link
@kvark

kvark Aug 24, 2018

Member

why is (*xx) needed here?

}
}

// Construct a brush that is an image wisth `stretch_size` dimensions and

This comment has been minimized.

Copy link
@kvark

kvark Aug 24, 2018

Member

"wisth"

BorderSource::Border { border, widths, .. } => {
let border = border.with_color(shadow.color);
BrushKind::new_border(border, widths)

This comment has been minimized.

Copy link
@kvark

kvark Aug 24, 2018

Member

nit: extra line

@kvark

This comment has been minimized.

Copy link
Member

commented Aug 24, 2018

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Aug 24, 2018

📌 Commit 2b8f3f5 has been approved by kvark

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Aug 24, 2018

⌛️ Testing commit 2b8f3f5 with merge 816ff14...

bors-servo added a commit that referenced this pull request Aug 24, 2018
Support shadows for Border and Image Brushes.

Fixed #2981

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2984)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Aug 24, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: kvark
Pushing 816ff14 to master...

@bors-servo bors-servo merged commit 2b8f3f5 into servo:master Aug 24, 2018
3 checks passed
3 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.