Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSupport shadows for Border and Image Brushes. #2984
Merged
Conversation
| top: border.top.into(), | ||
| right: border.right.into(), | ||
| bottom: border.bottom.into(), | ||
| widths: (*widths).into(), |
This comment has been minimized.
This comment has been minimized.
| } | ||
| } | ||
|
|
||
| // Construct a brush that is an image wisth `stretch_size` dimensions and |
This comment has been minimized.
This comment has been minimized.
| BorderSource::Border { border, widths, .. } => { | ||
| let border = border.with_color(shadow.color); | ||
| BrushKind::new_border(border, widths) | ||
|
|
This comment has been minimized.
This comment has been minimized.
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 24, 2018
Support shadows for Border and Image Brushes. Fixed #2981 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2984) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
djg commentedAug 24, 2018
•
edited by larsbergstrom
Fixed #2981
This change is