New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perspective interpolation fix for brush_blend #2991

Merged
merged 2 commits into from Aug 30, 2018

Conversation

Projects
None yet
3 participants
@kvark
Member

kvark commented Aug 28, 2018

Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1486113
This is a follow-up to #2939


This change is Reviewable

@kvark kvark requested a review from gw3583 Aug 28, 2018

@gw3583

gw3583 approved these changes Aug 28, 2018

It would be great to have a reftest for this, but if you want to get it merged asap and do that as a follow up, that's fine.

@kvark

This comment has been minimized.

Show comment
Hide comment
@kvark

kvark Aug 29, 2018

Member

@gw3583 please check the new commit where the reftest is added. FYI, the old result was:
screen-space-blit-old

Member

kvark commented Aug 29, 2018

@gw3583 please check the new commit where the reftest is added. FYI, the old result was:
screen-space-blit-old

@gw3583

This comment has been minimized.

Show comment
Hide comment
@gw3583
Contributor

gw3583 commented Aug 30, 2018

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Aug 30, 2018

Contributor

📌 Commit ec1507a has been approved by gw3583

Contributor

bors-servo commented Aug 30, 2018

📌 Commit ec1507a has been approved by gw3583

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Aug 30, 2018

Contributor

⌛️ Testing commit ec1507a with merge 5fa5c46...

Contributor

bors-servo commented Aug 30, 2018

⌛️ Testing commit ec1507a with merge 5fa5c46...

bors-servo added a commit that referenced this pull request Aug 30, 2018

Auto merge of #2991 - kvark:perspective-blend, r=gw3583
Perspective interpolation fix for brush_blend

Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1486113
This is a follow-up to #2939

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2991)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Aug 30, 2018

Contributor

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: gw3583
Pushing 5fa5c46 to master...

Contributor

bors-servo commented Aug 30, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: gw3583
Pushing 5fa5c46 to master...

@bors-servo bors-servo merged commit ec1507a into servo:master Aug 30, 2018

3 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment