New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backface visibility in nested stacking contexts. #2997

Merged
merged 1 commit into from Aug 30, 2018

Conversation

Projects
None yet
3 participants
@gw3583
Contributor

gw3583 commented Aug 30, 2018

Picture primitives should not consider the backface visibility
flag - they are containers for primitives only. Instead, if all
the primitives inside a picture are backface culled, then the
entire picture will be empty and also culled.

Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1442916.


This change is Reviewable

Fix backface visibility in nested stacking contexts.
Picture primitives should not consider the backface visibility
flag - they are containers for primitives only. Instead, if all
the primitives inside a picture are backface culled, then the
entire picture will be empty and also culled.

Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1442916.
@gw3583

This comment has been minimized.

Show comment
Hide comment
@gw3583
Contributor

gw3583 commented Aug 30, 2018

@kvark

kvark approved these changes Aug 30, 2018

Reviewed 4 of 4 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gw3583)


webrender/src/display_list_flattener.rs, line 1064 at r1 (raw file):

                &LayoutRect::zero(),
                &max_clip,
                true,

given the growing number of true arguments that are passed in this PR, we should switch to strongly typed enum, aka Backface::Visible

@kvark

This comment has been minimized.

Show comment
Hide comment
@kvark

kvark Aug 30, 2018

Member

Try looks good to me.
@bors-servo r+

Member

kvark commented Aug 30, 2018

Try looks good to me.
@bors-servo r+

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Aug 30, 2018

Contributor

📌 Commit 7d7d589 has been approved by kvark

Contributor

bors-servo commented Aug 30, 2018

📌 Commit 7d7d589 has been approved by kvark

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Aug 30, 2018

Contributor

⌛️ Testing commit 7d7d589 with merge 6447f20...

Contributor

bors-servo commented Aug 30, 2018

⌛️ Testing commit 7d7d589 with merge 6447f20...

bors-servo added a commit that referenced this pull request Aug 30, 2018

Auto merge of #2997 - gw3583:bf-fix, r=kvark
Fix backface visibility in nested stacking contexts.

Picture primitives should not consider the backface visibility
flag - they are containers for primitives only. Instead, if all
the primitives inside a picture are backface culled, then the
entire picture will be empty and also culled.

Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1442916.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2997)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Aug 30, 2018

Contributor

💔 Test failed - status-appveyor

Contributor

bors-servo commented Aug 30, 2018

💔 Test failed - status-appveyor

@gw3583

This comment has been minimized.

Show comment
Hide comment
@gw3583

gw3583 Aug 30, 2018

Contributor

It's not clear to me from the logs why this failed - timeout?

@bors-servo retry

Contributor

gw3583 commented Aug 30, 2018

It's not clear to me from the logs why this failed - timeout?

@bors-servo retry

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Aug 30, 2018

Contributor

⌛️ Testing commit 7d7d589 with merge 6415faa...

Contributor

bors-servo commented Aug 30, 2018

⌛️ Testing commit 7d7d589 with merge 6415faa...

bors-servo added a commit that referenced this pull request Aug 30, 2018

Auto merge of #2997 - gw3583:bf-fix, r=kvark
Fix backface visibility in nested stacking contexts.

Picture primitives should not consider the backface visibility
flag - they are containers for primitives only. Instead, if all
the primitives inside a picture are backface culled, then the
entire picture will be empty and also culled.

Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1442916.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2997)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Aug 30, 2018

Contributor

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: kvark
Pushing 6415faa to master...

Contributor

bors-servo commented Aug 30, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: kvark
Pushing 6415faa to master...

@bors-servo bors-servo merged commit 7d7d589 into servo:master Aug 30, 2018

3 of 4 checks passed

code-review/reviewable 1 discussion left (gw3583)
Details
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment