Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix scrolling on DDG HTML results page. #300
Merged
Conversation
There are a number of fixes / bandaids here: - get_scroll_layer() only returns a layer that is actually scrollable. - update the viewport transform when scrolling. - propagate the scrolling offset to scrollable child layers.
|
r? @pcwalton |
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jun 29, 2016
Fix scrolling on DDG HTML results page. There are a number of fixes / bandaids here: - get_scroll_layer() only returns a layer that is actually scrollable. - update the viewport transform when scrolling. - propagate the scrolling offset to scrollable child layers.
|
|
|
@bors-servo retry
|
bors-servo
added a commit
that referenced
this pull request
Jun 30, 2016
Fix scrolling on DDG HTML results page. There are a number of fixes / bandaids here: - get_scroll_layer() only returns a layer that is actually scrollable. - update the viewport transform when scrolling. - propagate the scrolling offset to scrollable child layers.
|
@bors-servo clean retry |
bors-servo
added a commit
that referenced
this pull request
Jun 30, 2016
Fix scrolling on DDG HTML results page. There are a number of fixes / bandaids here: - get_scroll_layer() only returns a layer that is actually scrollable. - update the viewport transform when scrolling. - propagate the scrolling offset to scrollable child layers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
glennw commentedJun 29, 2016
There are a number of fixes / bandaids here: