New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order of compositing operations with a single stacking context. #3001

Merged
merged 1 commit into from Aug 31, 2018

Conversation

Projects
None yet
4 participants
@gw3583
Contributor

gw3583 commented Aug 31, 2018

A rare case is that a stacking context has both a mix-blend-mode
and a filter list on it.

The CSS compositing specification says that filters should be
applied first, and then any compositing.

Fixing this will also simplify some upcoming optimizations that
make mix-blend-mode much faster in commonly used scenarios.


This change is Reviewable

Fix order of compositing operations with a single stacking context.
A rare case is that a stacking context has both a mix-blend-mode
and a filter list on it.

The CSS compositing specification says that filters should be
applied first, and then any compositing.

Fixing this will also simplify some upcoming optimizations that
make mix-blend-mode much faster in commonly used scenarios.
@gw3583

This comment has been minimized.

Show comment
Hide comment
@gw3583

gw3583 Aug 31, 2018

Contributor

r? @kvark or anyone

(I will kick off a try run shortly).

Contributor

gw3583 commented Aug 31, 2018

r? @kvark or anyone

(I will kick off a try run shortly).

@nical

nical approved these changes Aug 31, 2018

Looks good to me.

@gw3583

This comment has been minimized.

Show comment
Hide comment
Contributor

gw3583 commented Aug 31, 2018

@gw3583

This comment has been minimized.

Show comment
Hide comment
@gw3583

gw3583 Aug 31, 2018

Contributor

@bors-servo r=nical

Contributor

gw3583 commented Aug 31, 2018

@bors-servo r=nical

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Aug 31, 2018

Contributor

📌 Commit 9e9923b has been approved by nical

Contributor

bors-servo commented Aug 31, 2018

📌 Commit 9e9923b has been approved by nical

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Aug 31, 2018

Contributor

⌛️ Testing commit 9e9923b with merge 3fa5eb8...

Contributor

bors-servo commented Aug 31, 2018

⌛️ Testing commit 9e9923b with merge 3fa5eb8...

bors-servo added a commit that referenced this pull request Aug 31, 2018

Auto merge of #3001 - gw3583:filter-order, r=nical
Fix order of compositing operations with a single stacking context.

A rare case is that a stacking context has both a mix-blend-mode
and a filter list on it.

The CSS compositing specification says that filters should be
applied first, and then any compositing.

Fixing this will also simplify some upcoming optimizations that
make mix-blend-mode much faster in commonly used scenarios.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3001)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Aug 31, 2018

Contributor

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: nical
Pushing 3fa5eb8 to master...

Contributor

bors-servo commented Aug 31, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: nical
Pushing 3fa5eb8 to master...

@bors-servo bors-servo merged commit 9e9923b into servo:master Aug 31, 2018

3 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@kvark

This comment has been minimized.

Show comment
Hide comment
@kvark

kvark Aug 31, 2018

Member

@gw3583

Fixing this will also simplify some upcoming optimizations that
make mix-blend-mode much faster in commonly used scenarios.

I'm curious about the details here :)

Member

kvark commented Aug 31, 2018

@gw3583

Fixing this will also simplify some upcoming optimizations that
make mix-blend-mode much faster in commonly used scenarios.

I'm curious about the details here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment