Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow blob images to query font instance data #3002

Merged
merged 1 commit into from Aug 31, 2018

Conversation

@lsalzman
Copy link
Contributor

commented Aug 31, 2018

This feature is to help solve downstream Gecko bug https://bugzilla.mozilla.org/show_bug.cgi?id=1480615

We need to be able to recreate ScaledFonts in Gecko from WR's font instance data so that blob images and WR can line up their font usage. The only thing missing for doing this was a way to get the necessary font instance data back out. This just adds a simple query to BlobImageResources to do that.


This change is Reviewable

@kvark
kvark approved these changes Aug 31, 2018
@kvark

This comment has been minimized.

Copy link
Member

commented Aug 31, 2018

Looks harmless :)
@bors-servo r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Aug 31, 2018

📌 Commit bfc0533 has been approved by kvark

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Aug 31, 2018

⌛️ Testing commit bfc0533 with merge c488ea1...

bors-servo added a commit that referenced this pull request Aug 31, 2018
allow blob images to query font instance data

This feature is to help solve downstream Gecko bug https://bugzilla.mozilla.org/show_bug.cgi?id=1480615

We need to be able to recreate ScaledFonts in Gecko from WR's font instance data so that blob images and WR can line up their font usage. The only thing missing for doing this was a way to get the necessary font instance data back out. This just adds a simple query to BlobImageResources to do that.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3002)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Aug 31, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: kvark
Pushing c488ea1 to master...

@bors-servo bors-servo merged commit bfc0533 into servo:master Aug 31, 2018
3 checks passed
3 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.