Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove flat varying #3007

Closed
wants to merge 3 commits into from
Closed

Remove flat varying #3007

wants to merge 3 commits into from

Conversation

@djg
Copy link
Contributor

djg commented Sep 3, 2018

This addresses Issue #3004


This change is Reviewable

This leads to the need for ANGLE to generate geometry shaders so it can match
GL's `provoking vertex` behavior.
@jrmuizel
Copy link
Contributor

jrmuizel commented Sep 3, 2018

thread 'validate_shaders' panicked at 'Shader compilation failed: cs_border_segment
ERROR: 0:599: 'mod' : no matching overloaded function found
ERROR: 0:599: '/' : wrong operand types - no operation '/' exists that takes a left-hand operand of type 'in highp float' and a right operand of type 'const int' (or there is no acceptable conversion)
', webrender/tests/angle_shader_validation.rs:143:13
@djg djg force-pushed the djg:remove-flat-varying branch from b4f78dc to 9efe3ea Sep 3, 2018
@djg
Copy link
Contributor Author

djg commented Sep 3, 2018

thread 'validate_shaders' panicked at 'Shader compilation failed: cs_border_segment
ERROR: 0:599: 'mod' : no matching overloaded function found
ERROR: 0:599: '/' : wrong operand types - no operation '/' exists that takes a left-hand operand of type 'in highp float' and a right operand of type 'const int' (or there is no acceptable conversion)
', webrender/tests/angle_shader_validation.rs:143:13

Because 2 is not the same as 2.0 🤦‍♂️

@djg djg closed this Sep 4, 2018
@djg djg deleted the djg:remove-flat-varying branch Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.