Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Gecko with ImageRendering property when locking NativeTexture external images #3009

Merged
merged 5 commits into from Sep 4, 2018

Conversation

@hwinnemoe
Copy link
Contributor

hwinnemoe commented Sep 3, 2018

fixes #2993


This change is Reviewable

… external images, fixes #2993
@hwinnemoe
Copy link
Contributor Author

hwinnemoe commented Sep 3, 2018

@gw3583
Copy link
Collaborator

gw3583 commented Sep 4, 2018

Looks like the examples need to be updated:

error[E0050]: method `lock` has 3 parameters but the declaration in trait `webrender::ExternalImageHandler::lock` has 4
  --> examples\texture_cache_stress.rs:64:62
   |
64 |     fn lock(&mut self, _key: ExternalImageId, channel_index: u8) -> webrender::ExternalImage {
   |                                                              ^^ expected 4 parameters, found 3
   |
   = note: `lock` from trait: `fn(&mut Self, webrender::<unnamed>::ExternalImageId, u8, webrender::<unnamed>::ImageRendering) -> webrender::ExternalImage<'_>`
@gw3583
Copy link
Collaborator

gw3583 commented Sep 4, 2018

The change looks good to me, once the CI errors above are resolved, thanks!

@kvark
Copy link
Member

kvark commented Sep 4, 2018

@gw3583 We've got to start tracking the breaking changes more careful as WR gets published.
@bors-servo r=gw3583

@bors-servo
Copy link
Contributor

bors-servo commented Sep 4, 2018

📌 Commit cd93b95 has been approved by gw3583

@bors-servo
Copy link
Contributor

bors-servo commented Sep 4, 2018

Testing commit cd93b95 with merge d88b47c...

bors-servo added a commit that referenced this pull request Sep 4, 2018
Provide Gecko with ImageRendering property when locking NativeTexture external images

fixes #2993

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3009)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 4, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: gw3583
Pushing d88b47c to master...

@bors-servo bors-servo merged commit cd93b95 into servo:master Sep 4, 2018
3 checks passed
3 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@hwinnemoe hwinnemoe deleted the hwinnemoe:imageRenderingNativeTexture branch Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.