Skip to content

/ webrender

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to GLSL 1.30 on Linux. #301

Merged
merged 2 commits into from Jun 30, 2016
Merged

Switch to GLSL 1.30 on Linux. #301

merged 2 commits into from Jun 30, 2016

Conversation

@glennw
Copy link
Member

glennw commented Jun 29, 2016

This should allow us to run under xvfb for CI testing.
@gw3583
Switch to GLSL 1.30 on Linux.
Loading status checks…
e5a4166 
This should allow us to run under xvfb for CI testing.
@glennw
Copy link
Member Author

glennw commented Jun 29, 2016

r? @larsbergstrom or @pcwalton
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Jun 29, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jun 29, 2016

📌 Commit e5a4166 has been approved by larsbergstrom
@samlh
Copy link

samlh commented Jun 29, 2016 

src\device.rs:856:20: 856:34 error: unresolved name `SHADER_VERSION` [E0425]
src\device.rs:856         s.push_str(SHADER_VERSION);
                                     ^~~~~~~~~~~~~~
src\device.rs:856:20: 856:34 help: run `rustc --explain E0425` to see a detailed explanation
src\device.rs:856:20: 856:34 error: unresolved name `SHADER_VERSION` [E0425]
src\device.rs:856         s.push_str(SHADER_VERSION);
                                     ^~~~~~~~~~~~~~
src\device.rs:856:20: 856:34 help: run `rustc --explain E0425` to see a detailed explanation
error: aborting due to previous error

Missing the Windows case
@gw3583
add windows version
Loading status checks…
3cb054e
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Jun 29, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jun 29, 2016

📌 Commit 3cb054e has been approved by larsbergstrom
bors-servo added a commit that referenced this pull request Jun 30, 2016
@bors-servo
Auto merge of #301 - glennw:xvfb, r=larsbergstrom
Loading status checks…
c9c6117 
Switch to GLSL 1.30 on Linux.

This should allow us to run under xvfb for CI testing.
@bors-servo
Copy link
Contributor

bors-servo commented Jun 30, 2016

⌛ Testing commit 3cb054e with merge c9c6117...
@glennw
Copy link
Member Author

glennw commented Jun 30, 2016

@bors-servo retry

  • Travis issues
@bors-servo
Copy link
Contributor

bors-servo commented Jun 30, 2016

⌛ Testing commit 3cb054e with merge 1ce30fe...
bors-servo added a commit that referenced this pull request Jun 30, 2016
@bors-servo
Auto merge of #301 - glennw:xvfb, r=larsbergstrom
Loading status checks…
1ce30fe 
Switch to GLSL 1.30 on Linux.

This should allow us to run under xvfb for CI testing.
@Ms2ger Ms2ger merged commit 3cb054e into servo:master Jun 30, 2016
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
homu Testing commit 3cb054e with merge 1ce30fe...
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@glennw glennw deleted the glennw:xvfb branch Dec 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@glennw @larsbergstrom @bors-servo @samlh @Ms2ger @gw3583
You can’t perform that action at this time.