Skip to content

/ webrender

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be consistent about how the algorithm we use to modulate colors. #3010

Merged
merged 4 commits into from Sep 4, 2018
Merged

Be consistent about how the algorithm we use to modulate colors. #3010

merged 4 commits into from Sep 4, 2018
+87 −57

Commits on Sep 3, 2018

  1. Cleanup the way we compute the darker / lighter colors for inset / ou… 

    …tset borders.

Just so we have a single way to define the coefficients that we use to darken /
enlighten a color for these kinds of borders.
    @emilio
    emilio committed Sep 3, 2018
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    ec5710b

  2. Be consistent about how the algorithm we use to modulate colors. 

    In particular, if the color is black, every browser does its best to infer the
color.

Fixes: https://bugzilla.mozilla.org/show_bug.cgi?id=1488294

This should require a couple test updates in Gecko I presume.
    @emilio
    emilio committed Sep 3, 2018
    Loading status checks…
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    0fa7019

Commits on Sep 4, 2018

  1. Update reftests.

    @emilio
    emilio committed Sep 4, 2018
    Loading status checks…
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    28c4b4f

  2. Normalize small borders to solid.

    @emilio
    emilio committed Sep 4, 2018
    Loading status checks…
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    574bb24
You can’t perform that action at this time.